lookup.state & lookup.suburb - suggested change

Summary: for better international support, 1) change validation of code in lookup.state to [A-Z0-9_]* and 2) in lookup.suburb increase the max length of the postcode field to 10.

Discussion:

In the lookup.state the validation for code is '[A-Z]*' - this is different for the normal validation for the code field which is '[A-Z0-9_]*'

I got bitten by this when loading postcodes for South Africa. SA does not use provinces (its equivalents of states) in its postcodes, but rather 'areas' - which are effectively the name of the nearest reasonable sized town.  There are some 1061 of them, and a number of them are two words (eg Wingate Park).

When generating the xml data, I used my standard recipe to convert something to a code - uppercase and remove any ' and replace spaces by underlines.

However, for the two word areas, this ran foul of the [A-Z]* validation.

Can I suggest that we change the validation of code in lookup.state to the same as that in lookup.suburb and elsewhere - ie [A-Z0-9_]*

Note that the UK also uses a similar system or 'locations' and some of these are two word.

The UK situation reveals another problem - the postcode field in lookup.suburb has a maximum lenght of 6 characters. The UK postcodes can be up to 8 characters long (in the format 'AA99 9AA').

From http://en.wikipedia.org/wiki/Postal_code it would appear that we should increase the max lenght of the postcode field to 10 characters.

Regards, Tim G

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.

Re: lookup.state & lookup.suburb - suggested change

 I think this falls under

http://www.openvpms.org/project/openvpms-internationalization

and would be added to that projects specification.  

The critical thing with any internationalization changes is that they dont affect the current userbase negatively.  

ie default to lbs to kgs in the US but not here.

Not that these changes do...but this needs keeping in mind.

 

Ben

Regards
 
Ben 
OpenVPMS Installer and Helper 
Ph: +61423044823 
Email: info[at]charltonit.com[dot]au

Re: lookup.state & lookup.suburb - suggested change

Ben - again apologies for the tardy reply.

I don't think that these two adjustments to the archetype warrant being part of the internationalisation project - though they do address problems in using OpenVPMS in some countries. I will just Jira the change.

Can I Jira at the current time - or should I hold off for the moment?

Regards, Tim G

Syndicate content